Repository navigation
feat(stovepipe): add project status lookup by request ID - #840
Merged
Merged
Conversation
mnoah1
marked this pull request as ready for review
October 12, 2026 15:16
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 12, 2026 15:16
mnoah1
enabled auto-merge
October 12, 2026 15:16
prathshenoy
approved these changes
Oct 14, 2026
Summary: `Ingest` returns a request ID, but project status can only be queried by commit URI. Consumers need to inspect that request directly. Add `GetProjectStatusByID` with the same status fields and pagination as the URI API. Both endpoints use a shared `ProjectStatusController` and domain request/result types for validation, durable status reads, and pagination. Preserve the existing URI wire contract and its retryable summary-visibility gap; classify unknown IDs as lookup misses. Regenerate RPC bindings and update the project-status RFC. Test Plan: - Unit tests: `./tool/bazel test //stovepipe/controller:go_default_test //service/stovepipe/server/mapper:go_default_test //service/stovepipe/server/handler:go_default_test --test_output=errors`. - Docker integration: `./tool/bazel test //test/integration/stovepipe:go_default_test --test_output=errors`. Covers equivalent ID/URI responses, pagination across selectors, explicit green results, and queue isolation. - Repository checks: `make fmt`, `make lint`, `make check-tidy`, and `make check-gazelle`.
mnoah1
force-pushed
the
mnoah1/stovepipe-project-status-by-id
branch
from
October 15, 2026 19:27
e70605a to
661bc02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
We already have a way to look up an individual request by URI. Since we simplified the request ID format, it would also be helpful to have a way to look up a request based on ID. Adjust the existing GetProjectStatusByURI controller to support lookup by request ID, reusing the existing logic mostly as-is and returning an equivalent shape.
What?
Add
GetProjectStatusByIDwith the same status fields and pagination as the URI API. Both endpoints use a sharedProjectStatusControllerand domain request/result types for validation, durable status reads, and pagination. Preserve the existing URI wire contract and its retryable summary-visibility gap; classify unknown IDs as lookup misses.Regenerate RPC bindings and update the project-status RFC.
Test Plan
./tool/bazel test //stovepipe/controller:go_default_test //service/stovepipe/server/mapper:go_default_test //service/stovepipe/server/handler:go_default_test --test_output=errors../tool/bazel test //test/integration/stovepipe:go_default_test --test_output=errors. Covers equivalent ID/URI responses, pagination across selectors, explicit green results, and queue isolation.make fmt,make lint,make check-tidy, andmake check-gazelle.Issues